Force the elastic integration tests to use the correct IMAGE path for docker images#193
Merged
osullivandonal merged 5 commits intoelastic:mainfrom Jan 20, 2026
Conversation
The elastic integration tests that run in the CI start up the elastic demo using make start. This uses the .env.override file to set the IMAGE path to use the elastic versions of the images for this demo. However, upon investigation it was found that docker compose is not respecting this and just uses the value set in the .env file, which currently has a bug in the product catalog image.
rogercoll
reviewed
Jan 19, 2026
Collaborator
rogercoll
left a comment
rogercoll
left a comment
There was a problem hiding this comment.
Do you know why the .env.override is not taken into account? Is this only happening in our CI? (wondering if it is also failing in local execution)
Maybe DOCKER_COMPOSE_ENV is set?
Author
Works fine locally, seems to be the way docker compose works, I found an issue for something similar here. |
rogercoll
reviewed
Jan 19, 2026
Also resource the env vars in demo.sh as the sed-in-place works, we just need to update the env vars in the shell
The prevents the CI check erroring out when running locally
rogercoll
approved these changes
Jan 20, 2026
Collaborator
rogercoll
left a comment
rogercoll
left a comment
There was a problem hiding this comment.
Thanks for fixing this! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The elastic integration tests that run in the CI start up the elastic demo using make start. This uses the .env.override file to set the IMAGE path to use the elastic versions of the images for this demo. However, upon investigation it was found that docker compose is not respecting this and just uses the value set in the .env file, which currently has a bug in the product catalog image.
Looks like the issue here is that docker compose in the CI is not respecting the
.env.overridefile, it takes theIMAGEpath from the .env and not the.env.override. This causes theElastic integration teststo use the upstream images for the tests, and currently it looks like theproduct-catalgoimage is broken.Here is this repo before using
sedto update the image path in the tests:And when we use
sedto update theIMAGEenv var with the correct elastic path:See closed PR: #192
fixes #191