Skip to content

Conversation

@trentm
Copy link
Member

@trentm trentm commented Nov 29, 2024

@eedugon Some minor tweaks to the k8s operator docs that I noticed while reviewing #59

  • Correction (I think) to the namespace used in some kubectl commands in the Java and Python docs
  • Unfortunately my editor removes trailing whitespace and there were some in these docs, so the diff will be smaller if you hide whitespace differences.
  • Remove a duplicate header in the python doc.

@trentm trentm requested a review from eedugon November 29, 2024 22:17
@trentm trentm self-assigned this Nov 29, 2024
Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catches, thanks a lot!!!
LGTM :)

@eedugon
Copy link
Contributor

eedugon commented Dec 2, 2024

Btw, another doc where your insights and review would be very useful is the generic docs/kubernetes/operator/instrumenting-applications.md. That one has the links to the language specific docs that we've been working with recently.

@trentm trentm merged commit 27aabd1 into main Dec 2, 2024
1 check passed
@trentm trentm deleted the trentm/k8s-operator-doc-tweaks branch December 2, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants