feat: Add minutes-only timeout parameter to monitor config and format for Kibana#1114
Closed
maramos-elastic wants to merge 1 commit intoelastic:mainfrom
Closed
feat: Add minutes-only timeout parameter to monitor config and format for Kibana#1114maramos-elastic wants to merge 1 commit intoelastic:mainfrom
maramos-elastic wants to merge 1 commit intoelastic:mainfrom
Conversation
Add --timeout <minutes> CLI option to override the default monitor timeout. Similar to --schedule, this allows setting the timeout at the global, project, or individual monitor level. The timeout value is specified in minutes and is converted to the format expected by Kibana (e.g., '3m' for 3 minutes) when pushing monitors. Changes: - Add timeout field to MonitorConfig type - Add timeout to BaseArgs for CLI options - Add --timeout option to push command - Pass timeout through runner to monitor schema - Format timeout as string with 'm' suffix for Kibana API compatibility - Add unit tests for timeout formatting
Author
|
There's a design open issue Closing this PR in favor of #1113 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133
Summary
timeoutparameter for monitors.m) suffix (e.g.3m) to match Kibana's expected normalizationWhat changed
--timeout <minutes>and wire it through push commands.timeout?: numberto monitor config usage and include it in shared args.timeoutthrough monitor defaults.5m) and updateMonitorSchema.timeouttostringfor the outgoing payload.buildMonitorSchemaformatstimeoutas'5m'and omits it when unspecified.Verification
Run unit tests:
All tests passed
Manual push used for verification (example):
Notes for reviewers
scheduleparamRelease note
timeoutparameter to monitor configuration (minutes-only).