Rename stateful applications to hosted applications

[nick-benoit]

Description

Corresponds with GH team name change: https://github.com/orgs/elastic/teams/control-plane-hosted-applications

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improves code quality but has no user-facing effect)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation

Readiness Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

[claudia-correia]

👍

[dimuon]

The failed acc test is a flaky test I believe.

Does it make sense to change also the owner name in catalog-info?

[nick-benoit]

The failed acc test is a flaky test I believe.

Does it make sense to change also the owner name in catalog-info?

Yes, that is also important. All of our repos in catalog-info have already been updated at this point though (link).

[dimuon]

The failed acc test is a flaky test I believe.
Does it make sense to change also the owner name in catalog-info?

Yes, that is also important. All of our repos in catalog-info have already been updated at this point though (link).

Shall we change it in the repo too? E.g.:

• https://github.com/elastic/terraform-provider-ec/blob/master/catalog-info.yaml#L14
• https://github.com/elastic/terraform-provider-ec/blob/master/catalog-info.yaml#L40

[nick-benoit]

Ahh I see what you mean. I think that will need to happen when we rename this team: https://github.com/orgs/elastic/teams/control-plane-stateful

Which I think is being coordinated to happen when we rename foundations soon.

[dimuon]

That team is empty. We have already the correct one - https://github.com/orgs/elastic/teams/control-plane-hosted-applications.

[nick-benoit]

It is empty, but it is configured of the parent team of our team. I think it will cause permission issues if we change the reference without changing the name of the team I linked to.

The idea was to prepare all the PRs and change the other team names (foundations / stateful combined team) after I finish the rename effort for our team (which is unfortunately a much larger effort than you'd expect)

[dimuon]

Though, it seems, you approved the similar change for the other provider.

[nick-benoit]

Right, the scope of the changes we're making now (and in the PR you linked) is only to update control-plane-stateful-applications to control-plane-hosted-applications (which is also what I did with this PR).

The files you linked to

• https://github.com/elastic/terraform-provider-ec/blob/master/catalog-info.yaml#L14
• https://github.com/elastic/terraform-provider-ec/blob/master/catalog-info.yaml#L40

reference control-plane-stateful which has not been changed yet. We will want to coordinate this name change with the eng prod team and have not yet done so.

Or at least I think that is what you're asking about / suggesting. It is certainly a bit confusing 🙂

[dimuon]

Honestly, I don't understand why we use control-plane-stateful in catalog-info in this repo. IMO the owner name should be the same as in terraform-provider-elasticstack.

Anyway, thank you for the detailed answers. Let's update the owner field here later on.