Skip to content

Improve error messaging if no Kibana endpoint is configured. #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Improve error messaging if no Kibana endpoint is configured. #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/clients/api_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,12 +363,14 @@ func (a *ApiClient) ServerVersion(ctx context.Context) (*version.Version, diag.D
func (a *ApiClient) versionFromKibana() (*version.Version, diag.Diagnostics) {
kibClient, err := a.GetKibanaClient()
if err != nil {
return nil, diag.FromErr(err)
return nil, diag.Errorf("failed to get version from Kibana API: %s, "+
"please ensure a working 'kibana' endpoint is configured", err.Error())
}

status, err := kibClient.KibanaStatus.Get()
if err != nil {
return nil, diag.FromErr(err)
return nil, diag.Errorf("failed to get version from Kibana API: %s, "+
"Please ensure a working 'kibana' endpoint is configured", err.Error())
}

vMap, ok := status["version"].(map[string]interface{})
Expand Down
3 changes: 3 additions & 0 deletions internal/fleet/agent_policy/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ func (r *agentPolicyResource) Update(ctx context.Context, req resource.UpdateReq

sVersion, e := r.client.ServerVersion(ctx)
if e != nil {
for _, a := range e {
resp.Diagnostics.AddError(a.Summary, a.Detail)
}
return
}

Expand Down
Loading