Skip to content

Conversation

tobio
Copy link
Member

@tobio tobio commented Jun 4, 2025

Mostly done by Windsurf so I guess there could be dragons... I think I've found the insane bits though.

@tobio tobio requested a review from dimuon June 4, 2025 07:30
@tobio tobio self-assigned this Jun 4, 2025
@tobio tobio requested a review from a team July 3, 2025 10:47
VersionConstraint: "0.11.15",
},
},
ProtoV6ProviderFactories: acctest.Providers,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it if we rely on ExternalProviders?

}

var userPassword models.UserPassword
// TB TODO Fix up this logic. It should only set the password when it's set in config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we fix this in this PR or in a follow-up one?

dimuon
dimuon previously approved these changes Jul 3, 2025
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides 2 nit-picks and the missing changelog 👍

@tobio tobio merged commit f1bf782 into main Jul 6, 2025
48 checks passed
@tobio tobio deleted the vibe-framework branch July 6, 2025 06:04
tobio added a commit that referenced this pull request Jul 7, 2025
* origin/main:
  fix(deps): update module github.com/hashicorp/terraform-plugin-docs to v0.22.0 (#1188)
  Bump github.com/cloudflare/circl from 1.6.0 to 1.6.1 in /tools (#1187)
  Migrate the System User resource to the plugin framework.  (#1154)
  Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools (#1184)
  Bump golang.org/x/net from 0.36.0 to 0.38.0 in /libs/go-kibana-rest (#1183)
tobio added a commit that referenced this pull request Jul 7, 2025
* origin/main:
  Move tools to go.mod managed tools (#1185)
  fix(deps): update module github.com/hashicorp/terraform-plugin-docs to v0.22.0 (#1188)
  Bump github.com/cloudflare/circl from 1.6.0 to 1.6.1 in /tools (#1187)
  Migrate the System User resource to the plugin framework.  (#1154)
  Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools (#1184)
  Bump golang.org/x/net from 0.36.0 to 0.38.0 in /libs/go-kibana-rest (#1183)
  chore(deps): update golang:1.24.4 docker digest to 20a022e (#1177)
  Bump github.com/getkin/kin-openapi from 0.127.0 to 0.131.0 in /tools (#1181)
tobio added a commit to agunnerson-elastic/terraform-provider-elasticstack that referenced this pull request Jul 8, 2025
* origin/main: (23 commits)
  Regenerate Kibana client (elastic#1189)
  Addressing feedback on elastic#1178 (elastic#1180)
  Bump github.com/getkin/kin-openapi from 0.127.0 to 0.131.0 (elastic#1190)
  Remove explicit misspell (elastic#1182)
  Move tools to go.mod managed tools (elastic#1185)
  fix(deps): update module github.com/hashicorp/terraform-plugin-docs to v0.22.0 (elastic#1188)
  Bump github.com/cloudflare/circl from 1.6.0 to 1.6.1 in /tools (elastic#1187)
  Migrate the System User resource to the plugin framework.  (elastic#1154)
  Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools (elastic#1184)
  Bump golang.org/x/net from 0.36.0 to 0.38.0 in /libs/go-kibana-rest (elastic#1183)
  chore(deps): update golang:1.24.4 docker digest to 20a022e (elastic#1177)
  Bump github.com/getkin/kin-openapi from 0.127.0 to 0.131.0 in /tools (elastic#1181)
  Add basic docs around the current kbapi generation (elastic#1178)
  chore(deps): update module github.com/golangci/golangci-lint to v2.2.1 (elastic#1176)
  chore(deps): update docker.elastic.co/elasticsearch/elasticsearch docker tag to v9.0.3 (elastic#1170)
  chore(deps): update docker.elastic.co/kibana/kibana docker tag to v9.0.3 (elastic#1171)
  chore(deps): update dependency go to v1.24.4 (elastic#1159)
  fix(deps): update module github.com/elastic/go-elasticsearch/v8 to v8.18.1 (elastic#1168)
  chore(deps): update golang docker tag to v1.24.4 (elastic#1161)
  fix(deps): update module github.com/goreleaser/goreleaser/v2 to v2.10.2 (elastic#1162)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants