-
Notifications
You must be signed in to change notification settings - Fork 122
Migrate the System User resource to the plugin framework. #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
make docs-generate
VersionConstraint: "0.11.15", | ||
}, | ||
}, | ||
ProtoV6ProviderFactories: acctest.Providers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it if we rely on ExternalProviders
?
} | ||
|
||
var userPassword models.UserPassword | ||
// TB TODO Fix up this logic. It should only set the password when it's set in config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we fix this in this PR or in a follow-up one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides 2 nit-picks and the missing changelog 👍
* origin/main: fix(deps): update module github.com/hashicorp/terraform-plugin-docs to v0.22.0 (#1188) Bump github.com/cloudflare/circl from 1.6.0 to 1.6.1 in /tools (#1187) Migrate the System User resource to the plugin framework. (#1154) Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools (#1184) Bump golang.org/x/net from 0.36.0 to 0.38.0 in /libs/go-kibana-rest (#1183)
* origin/main: Move tools to go.mod managed tools (#1185) fix(deps): update module github.com/hashicorp/terraform-plugin-docs to v0.22.0 (#1188) Bump github.com/cloudflare/circl from 1.6.0 to 1.6.1 in /tools (#1187) Migrate the System User resource to the plugin framework. (#1154) Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools (#1184) Bump golang.org/x/net from 0.36.0 to 0.38.0 in /libs/go-kibana-rest (#1183) chore(deps): update golang:1.24.4 docker digest to 20a022e (#1177) Bump github.com/getkin/kin-openapi from 0.127.0 to 0.131.0 in /tools (#1181)
* origin/main: (23 commits) Regenerate Kibana client (elastic#1189) Addressing feedback on elastic#1178 (elastic#1180) Bump github.com/getkin/kin-openapi from 0.127.0 to 0.131.0 (elastic#1190) Remove explicit misspell (elastic#1182) Move tools to go.mod managed tools (elastic#1185) fix(deps): update module github.com/hashicorp/terraform-plugin-docs to v0.22.0 (elastic#1188) Bump github.com/cloudflare/circl from 1.6.0 to 1.6.1 in /tools (elastic#1187) Migrate the System User resource to the plugin framework. (elastic#1154) Bump github.com/go-viper/mapstructure/v2 from 2.2.1 to 2.3.0 in /tools (elastic#1184) Bump golang.org/x/net from 0.36.0 to 0.38.0 in /libs/go-kibana-rest (elastic#1183) chore(deps): update golang:1.24.4 docker digest to 20a022e (elastic#1177) Bump github.com/getkin/kin-openapi from 0.127.0 to 0.131.0 in /tools (elastic#1181) Add basic docs around the current kbapi generation (elastic#1178) chore(deps): update module github.com/golangci/golangci-lint to v2.2.1 (elastic#1176) chore(deps): update docker.elastic.co/elasticsearch/elasticsearch docker tag to v9.0.3 (elastic#1170) chore(deps): update docker.elastic.co/kibana/kibana docker tag to v9.0.3 (elastic#1171) chore(deps): update dependency go to v1.24.4 (elastic#1159) fix(deps): update module github.com/elastic/go-elasticsearch/v8 to v8.18.1 (elastic#1168) chore(deps): update golang docker tag to v1.24.4 (elastic#1161) fix(deps): update module github.com/goreleaser/goreleaser/v2 to v2.10.2 (elastic#1162) ...
Mostly done by Windsurf so I guess there could be dragons... I think I've found the insane bits though.