Skip to content

Conversation

nikhilsbhat
Copy link
Contributor

This PR introduces support for specifying a custom endpoint in the S3-based snapshot repository configuration. It allows users to define a custom S3-compatible storage endpoint instead of relying solely on AWS defaults.

✅ Changes

  • Added support for endpoint configuration in snapshot repository settings.
  • Enables use of custom or on-prem S3-compatible storage services.

🔧 Use Case
Useful for setups involving:

  • MinIO or other S3-compatible backends
  • VPC endpoints

🔗 Related Issue
Potentially fixes #1096

@cla-checker-service
Copy link

cla-checker-service bot commented Jun 5, 2025

💚 CLA has been signed

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this in! Code LGTM. Are you able to:

  • Sign the CLA
  • Run make docs-generate and commit the result
  • Add an entry to CHANGELOG.md for this PR

@nikhilsbhat
Copy link
Contributor Author

Thanks for adding this in! Code LGTM. Are you able to:

  • Sign the CLA
  • Run make docs-generate and commit the result
  • Add an entry to CHANGELOG.md for this PR

@tobio, thanks for the review! I've completed all of them. Let me know if there's anything else needed from my side.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking the time here!

@tobio tobio merged commit 6ea1d5e into elastic:main Jun 8, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] elasticstack_elasticsearch_snapshot_repository does not support "endpoint" attribute for S3 repo

2 participants