Add slo_id length validation #1173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
tobio
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
LGTM, thanks for taking the time to improve the provider!
@jakubpetrovic are you able to sign the CLA so we can get this merged?
|
@tobio i'm on it, just ensuring there are no legal/ip issues. Will sign soon, hopefully |
|
@tobio unfortunately our legal team advised me to not contribute due to conflict of interest. Therefore i have to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1144
Wasn't sure if the max length should be 48 as api docs state 36, but after testing in dev tools it looks like 48 is indeed max at least in 9.0.0