Add description to kibana role resource #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobio
force-pushed
the
kb-role-description
branch
from
93c07ea to
c7feb8e
Compare
tobio
force-pushed
the
kb-role-description
branch
from
c7feb8e to
0c6fff4
Compare
wandergeek
previously approved these changes
Jul 8, 2025
| roleName := sdkacctest.RandStringFromCharSet(10, sdkacctest.CharSetAlphaNum) | ||
| roleNameRemoteIndices := sdkacctest.RandStringFromCharSet(10, sdkacctest.CharSetAlphaNum) | ||
| minSupportedRemoteIndicesVersion := version.Must(version.NewSemver("8.10.0")) | ||
| minSupportedDescriptionVersion := version.Must(version.NewVersion("8.15.0")) |
There was a problem hiding this comment.
I most likely don't have the context but I'm curious why these min versions have to be repeated everywhere?
tobio
added a commit
to agunnerson-elastic/terraform-provider-elasticstack
that referenced
this pull request
Jul 8, 2025
* origin/main: Add description to kibana role resource (elastic#1186)
snobear
added a commit
to snobear/terraform-provider-elasticstack
that referenced
this pull request
Aug 7, 2025
…idation errors The description field was being set unconditionally in resourceRoleRead, which caused Terraform to reject the plan when the description was empty because it was trying to set a non-computed attribute to an empty string. This fix ensures that the description field is only set when it contains actual content, preventing the 'Provider produced invalid plan' error for elasticstack_kibana_security_role resources without descriptions. Fixes: elastic#1186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1172