- 
                Notifications
    You must be signed in to change notification settings 
- Fork 121
[ISSUE-125] Add allow_restricted_indices setting to security role #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
         RobsonSutton
  
      
      
      commented
      
            RobsonSutton
  
      
      
      commented
        Jul 23, 2022 
      
    
  
- Add allow_restricted_indices setting (identified as missing: [Bug] Unable to use the option allow_restricted_indices when creating security role #125)
| Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? | 
| Also, elastic/elasticsearch#88751 raised to update the create / update security role docs to include allow_restricted_indices attribute. @Kushmaro / @olksdr - Hi both 👋 Please can you review and provide some feedback on this one when you get a chance? Thanks! | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor style nit to be consistent with the existing code.
| jenkins test this | 
| jenkins test this | 
| @RobsonSutton sorry for the back and forth, I'm new to this repo. Are you able to add a changelog entry for this PR as well please? | 
| @tobio - No probs! apologies, completely missed this! | 
| jenkins test this |