Skip to content

Conversation

@RobsonSutton
Copy link
Contributor

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@RobsonSutton
Copy link
Contributor Author

Also, elastic/elasticsearch#88751 raised to update the create / update security role docs to include allow_restricted_indices attribute.

@Kushmaro / @olksdr - Hi both 👋 Please can you review and provide some feedback on this one when you get a chance? Thanks!

@d-carmo d-carmo requested review from dimuon and tobio July 25, 2022 11:57
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor style nit to be consistent with the existing code.

@tobio
Copy link
Member

tobio commented Jul 25, 2022

jenkins test this

@tobio
Copy link
Member

tobio commented Jul 25, 2022

jenkins test this

@tobio
Copy link
Member

tobio commented Jul 25, 2022

@RobsonSutton sorry for the back and forth, I'm new to this repo. Are you able to add a changelog entry for this PR as well please?

@RobsonSutton
Copy link
Contributor Author

@tobio - No probs! apologies, completely missed this!

@tobio
Copy link
Member

tobio commented Jul 25, 2022

jenkins test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants