Don't allowlist API operations within the Kibana API spec #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Kibana API spec integration by updating references to use fully qualified type names instead of simplified type aliases. The changes ensure compatibility with the complete Kibana API specification without allowlisting specific operations.
- Updates monitoring type references in Fleet agent policy models
- Corrects package policy format parameter type reference
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/fleet/agent_policy/models.go | Updates monitoring enum references to use fully qualified type names |
| internal/clients/fleet/fleet.go | Updates format parameter to use fully qualified type name |
gigerdo
previously approved these changes
Sep 4, 2025
Instead generate a client covering all available endpoints
gigerdo
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1265
Are all these generated models correct? No idea, but it's what Kibana describes. Stack developers should be able to fix request/response models at the source (i.e the Kibana repo) when adding new resources.