Add export saved objects data source

[tehbooom]

Exports saved objects with the following

data "elasticstack_kibana_export_saved_objects" "example" {
  space_id                = "default"
  exclude_export_details  = true
  include_references_deep = true
  objects = jsonencode([
    {
      "type" : "dashboard",
      "id" : "7c5f07ee-7e41-4d50-ae1f-dfe54cc87209"
    }
  ])
}

output "saved_objects" {
  value = data.elasticstack_kibana_export_saved_objects.example.exported_objects
}

Tested on version 9.1.0

This PR will close #688

[tobio]

Thanks for taking the time to add this one in! We'd want this implemented with the terraform-plugin-framework rather than the old SDKv2, similarly to how import_saved_objects is implemented.

[tehbooom]

@tobio running make lint and make docs-generate shows no change for me and is passing locally.

I'm not sure why CI is failing

I see you changed the generation here 0da7e29 should be fixed now. disregard

[tobio]

Couple of comments, but they all stem back to using a richer input schema. You'll need to regenerate the docs again after the schema change too :)

Otherwise, LGTM

[tobio]

Suggested change

	"objects": schema.StringAttribute{
	Description: "JSON-encoded list of objects to export. Each object should have 'type' and 'id' fields.",
	Required: true,
	},
	"objects": schema.ListNestedAttribute{
	Description: "List of objects to export.",
	Required: true,
	Validators: []validator.List{
	listvalidator.SizeAtLeast(1),
	},
	NestedObject: schema.NestedAttributeObject{
	Attributes: map[string]schema.Attribute{
	"type": schema.StringAttribute{
	Description: "The type of the saved object.",
	Required: true,
	},
	"id": schema.StringAttribute{
	Description: "The ID of the saved object.",
	Required: true,
	},
	},
	},
	},

We can make this much simpler for users by fully defining the input schema here.

[tobio]

Assuming the schema change above

Suggested change

	var objectsList kbapi.PostSavedObjectsExportJSONBodyHasReference1
	objectsJSON := config.Objects.ValueString()
	var rawObjects []map[string]interface{}
	if err := json.Unmarshal([]byte(objectsJSON), &rawObjects); err != nil {
	resp.Diagnostics.AddError("Invalid objects JSON", fmt.Sprintf("Error parsing objects JSON: %v", err))
	return
	}
	for _, obj := range rawObjects {
	id, ok := obj["id"].(string)
	if !ok {
	resp.Diagnostics.AddError("Invalid object", "Object missing 'id' field")
	return
	}
	objType, ok := obj["type"].(string)
	if !ok {
	resp.Diagnostics.AddError("Invalid object", "Object missing 'type' field")
	return
	}
	objectsList = append(objectsList, struct {
	Id string `json:"id"`
	Type string `json:"type"`
	}{
	Id: id,
	Type: objType,
	})
	}
	objectsList := utils.ListTypeToSlice(ctx, config.Objects, path.Root("objects"), &resp.Diagnostics, func(item objectModel, meta utils.ListMeta) struct {
	Id string `json:"id"`
	Type string `json:"type"`
	} {
	return struct {
	Id string `json:"id"`
	Type string `json:"type"`
	}{
	Id: item.ID.ValueString(),
	Type: item.Type.ValueString(),
	}
	})

[tobio]

Assuming the schema change above

Suggested change

	}
	}
	type objectModel struct {
	Type types.String `tfsdk:"type"`
	ID types.String `tfsdk:"id"`
	}

[tobio]

Suggested change

	objects = jsonencode([
	{
	"type": "action",
	"id": elasticstack_kibana_action_connector.test.connector_id
	}
	])
	objects = [
	{
	type = "action",
	id = elasticstack_kibana_action_connector.test.connector_id
	}
	]

[tobio]

Suggested change

	Objects types.String `tfsdk:"objects"`
	Objects types.List `tfsdk:"objects"`

[tobio]

🎉 thanks for adding this