Security Detection Rule Updates #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-benoit
force-pushed
the
security-detection-rule-updates
branch
from
c7799a4 to
9937ac5
Compare
nick-benoit
changed the title
nick-benoit
force-pushed
the
security-detection-rule-updates
branch
from
be8d600 to
d5f8971
Compare
nick-benoit
changed the title
tobio
reviewed
Oct 14, 2025
| } | ||
|
|
||
| // convertThreatToModel converts kbapi.SecurityDetectionsAPIThreatArray to Terraform model | ||
| func convertThreatToModel(ctx context.Context, apiThreats *kbapi.SecurityDetectionsAPIThreatArray) (types.List, diag.Diagnostics) { |
internal/kibana/security_detection_rule/models_to_api_type_utils.go
Outdated
Show resolved
Hide resolved
internal/kibana/security_detection_rule/models_to_api_type_utils.go
Outdated
Show resolved
Hide resolved
internal/kibana/security_detection_rule/models_to_api_type_utils.go
Outdated
Show resolved
Hide resolved
internal/kibana/security_detection_rule/models_to_api_type_utils.go
Outdated
Show resolved
Hide resolved
internal/kibana/security_detection_rule/models_machine_learning.go
Outdated
Show resolved
Hide resolved
…ls.go Co-authored-by: Toby Brain <[email protected]>
…ls.go Co-authored-by: Toby Brain <[email protected]>
…ls.go Co-authored-by: Toby Brain <[email protected]>
…ls.go Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
…g.go Co-authored-by: Toby Brain <[email protected]>
Added changelog: 4e9621a |
tobio
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
threatquerynot being setindexandfiltersanomaly_thresholdtimeline_idandtimeline_titlefields""Each change is self contained in a single commit, so it might be easier to review each separately.
Note: In general we want to move away from adding validations in
models_*files I added some here due to time constraints. As part of the next milestone I plan to swap these out for validations at the schema level.