more fleet framework migrations #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemitus
force-pushed
the
feat
branch
2 times, most recently
from
496d992 to
9854819
Compare
This was referenced Sep 26, 2024
tobio
reviewed
Sep 27, 2024
tobio
reviewed
Sep 27, 2024
|
I was having problems earlier testing those, I think it has to do with on
read, not knowing if they should be false or null. I'll try that bit again
with a computerd/default false, and on read set false if not set.
Regarding the x-pointers flag, I can revert that. Will just need to change
up the helpers to do pointers instead. As you said, it doesn't change much.
As you've brought up manipulation of the published spec, whats your take
then on all of the nested anonymous structs? Fleet isn't too bad, but
Kibana's is a disaster for generation at the moment.
…On Thu, Sep 26, 2024, 11:26 PM Toby Brain ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In internal/fleet/agent_policy/resource_test.go
<#785 (comment)>
:
> @@ -57,7 +57,7 @@ func TestAccResourceAgentPolicy(t *testing.T) {
ResourceName: "elasticstack_fleet_agent_policy.test_policy",
ImportState: true,
ImportStateVerify: true,
- ImportStateVerifyIgnore: []string{"skip_destroy"},
+ ImportStateVerifyIgnore: []string{"monitor_metrics", "monitor_logs", "skip_destroy"},
What's happening here? This PR populates these fields on Read, why are we
not setting them to computed?
—
Reply to this email directly, view it on GitHub
<#785 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMTBCAIQCRDCIZZRAEOD3ZYTGABAVCNFSM6AAAAABOR4KYFKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZSGY3TSNRTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
.com>
|
|
ok.
|
Yea, these are a total pain. Ultimately we need to fix these in the source though so anyone using the specs can benefit. |
tobio
approved these changes
Sep 29, 2024
|
And here I couldn't sleep this morning. Looks like I'll be rebasing the
other pr now.
…On Sun, Sep 29, 2024, 6:36 AM Toby Brain ***@***.***> wrote:
Merged #785
<#785>
into main.
—
Reply to this email directly, view it on GitHub
<#785 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMTBBUUAZ3CAOFV6TBUXDZY7J2VAVCNFSM6AAAAABOR4KYFKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQ2DIOJTGI2TGOI>
.
You are receiving this because you authored the thread.Message ID:
<elastic/terraform-provider-elasticstack/pull/785/issue_event/14444932539@
github.com>
|
kjwardy
pushed a commit
to kjwardy/terraform-provider-elasticstack
that referenced
this pull request
Sep 30, 2024
* impl fw resource.agent_policy * impl fw resource/data_source integration * impl fw resource.fleet_server_host * update changelog * pull in sysMonitoring update * requested changes * fix *[] usage
tobio
added a commit
that referenced
this pull request
Sep 30, 2024
* origin/main: (39 commits) chore(deps): update golang:1.23.1 docker digest to 4f063a2 (#804) fix(deps): update module github.com/go-resty/resty/v2 to v2.15.3 (#781) fix for http/tcp monitor produces inconsistent result after apply (#801) chore(deps): update docker.elastic.co/elasticsearch/elasticsearch docker tag to v8.15.2 (#798) chore(deps): update docker.elastic.co/kibana/kibana docker tag to v8.15.2 (#799) Bump github.com/oapi-codegen/oapi-codegen/v2 in /tools (#808) Bump github.com/oapi-codegen/oapi-codegen/v2 from 2.4.0 to 2.4.1 (#806) Bump actions/checkout from 4.1.7 to 4.2.0 (#807) more fleet framework migrations (#785) Apply the sys_monitoring attribute during creation (#792) fix(deps): update module github.com/oapi-codegen/oapi-codegen/v2 to v2.4.0 (#788) fix(docs): indices datesource example field (#786) fix(deps): update module github.com/hashicorp/terraform-plugin-framework to v1.12.0 (#782) chore(deps): pin golang docker tag to 2fe82a3 (#783) Remove GO_VERSION indirection Fix release pipeline Prepare release v0.11.7 fix(deps): update module github.com/goreleaser/goreleaser/v2 to v2.3.2 (#776) impl framework data_source.fleet_enrollment_tokens (#778) Add support for the `alerts_filter` param in the Create Rule API (#774) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*[]sometypeand*map[string]sometypefields