Skip to content

Conversation

@daemitus
Copy link
Contributor

No description provided.

tobio
tobio previously approved these changes Oct 1, 2024
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@daemitus
Copy link
Contributor Author

daemitus commented Oct 1, 2024

I'll take care of the merge conflicts in a bit

@daemitus
Copy link
Contributor Author

daemitus commented Oct 1, 2024

I'll take care of the merge conflicts in a bit

notable changes post force-push:

  • internal.clients.fleet.fleet:
    • yanked reportUnknownError (unused sdk)
    • renamed reportUnknownErrorFw to reportUnknownError
    • dropped fwdiag alias, just diag now. There are no more sdk diags in all of fleet.
  • internal.fleet.shared:
    • deleted the whole file, unused SDK getFleetClient fn.

@tobio tobio merged commit 845721a into elastic:main Oct 1, 2024
20 checks passed
@daemitus daemitus deleted the outputs branch October 1, 2024 22:35
tobio added a commit that referenced this pull request Oct 3, 2024
* origin/main:
  fix package policy secrets (#821)
  chore(deps): update codecov/codecov-action digest to b9fd7d1 (#815)
  Bump release memory
  Switch to golang 1.23.2 in release
  Bump release memory
  Prepare release v0.11.8 (#810)
  Add key_id as an explicit attribute (#789)
  standalone-output resource (#811)
  Add URL support to data_view field_formats (#812)
  migrate fleet integration_policy to framework, fix secret churn (#797)
  Allow mappings to be unknown to support mappings defined in index templates (#803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants