Skip to content

Conversation

ottramst
Copy link
Contributor

@ottramst ottramst commented Oct 4, 2024

Add aliases to elasticstack_elasticsearch_transform resource.

Resolves #817

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for making both of these additions. They're great updates!

@tobio
Copy link
Member

tobio commented Oct 4, 2024

It looks like the committed docs don't match the generated output. You should be able to just run make docs-generate and commit the result.

@ottramst
Copy link
Contributor Author

ottramst commented Oct 7, 2024

Updated documentation as well :)

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks for taking the time with both these contributions.

@tobio tobio enabled auto-merge (squash) October 7, 2024 11:51
@tobio tobio merged commit 244eb08 into elastic:main Oct 7, 2024
20 checks passed
@ottramst ottramst deleted the add-transform-alias branch October 7, 2024 12:08
kjwardy pushed a commit to kjwardy/terraform-provider-elasticstack that referenced this pull request Oct 21, 2024
* Add aliases to transform resource

* Update changelog and docs

* Update internal/elasticsearch/transform/transform.go

Co-authored-by: Toby Brain <[email protected]>

* Update internal/elasticsearch/transform/transform.go

Co-authored-by: Toby Brain <[email protected]>

* Update docs generation

* Add version constraints to tests

* Add version constraints to aliases

---------

Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Missing field aliases for elasticstack_elasticsearch_transform resource

2 participants