Alerting fields should be Elastic durations, not Golang durations #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
previously approved these changes
Oct 15, 2024
adcoelho
reviewed
Oct 16, 2024
Co-authored-by: Antonio <[email protected]>
adcoelho
approved these changes
Oct 16, 2024
kjwardy
pushed a commit
to kjwardy/terraform-provider-elasticstack
that referenced
this pull request
Oct 21, 2024
…astic#846) * Alerting fields should be Elastic durations, not Golang durations * Changelog * PR feedback * Ok golangci-lint * Update internal/kibana/alerting.go Co-authored-by: Antonio <[email protected]> --------- Co-authored-by: Antonio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829
Fixes #770
Updates validation to check attributes are Elastic durations, not Golang durations.