-
Notifications
You must be signed in to change notification settings - Fork 122
EPM fixes #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPM fixes #854
Conversation
Additionally, I need to check if the diags by value issue is also in all the utils/tfsdk.go helper methods.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 couple of minor comments on the code.
Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
Co-authored-by: Toby Brain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, 🎉
* fix epm * changelog * Update internal/fleet/integration/resource_test.go Co-authored-by: Toby Brain <[email protected]> * Update internal/fleet/integration/resource_test.go Co-authored-by: Toby Brain <[email protected]> * Update internal/fleet/integration/resource_test.go Co-authored-by: Toby Brain <[email protected]> * Update internal/clients/fleet/fleet.go Co-authored-by: Toby Brain <[email protected]> * import and formatting * i should really fmt locally first --------- Co-authored-by: Toby Brain <[email protected]>
So there's a number of problems that cropped up.
allOf.1
needs to be under.item
which is present inallOf.0
. All the more reason to get the Pull newer fleet schema #834 to a satisfactory state.Actual:
Expected (using ti_abusech on one of the older stack versions):