Accept API keys for running acceptance tests #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobio
approved these changes
Jan 10, 2025
tobio
added a commit
to arenard/terraform-provider-elasticstack
that referenced
this pull request
Jan 11, 2025
…primary-shard-docs * origin/main: (76 commits) Bump golang.org/x/net from 0.27.0 to 0.33.0 in /libs/go-kibana-rest (elastic#981) Bump golang.org/x/net from 0.28.0 to 0.33.0 (elastic#980) Update go version in go-kibana-rest (elastic#978) Bump golang.org/x/crypto from 0.25.0 to 0.31.0 in /libs/go-kibana-rest (elastic#947) chore(deps): pin dependencies (elastic#972) Accept API keys for running acceptance tests (elastic#951) Bump github.com/go-git/go-git/v5 from 5.12.0 to 5.13.0 in /tools (elastic#977) Bump golang.org/x/crypto from 0.28.0 to 0.31.0 (elastic#960) fix(deps): update module github.com/goreleaser/goreleaser/v2 to v2.5.1 (elastic#976) chore(deps): update actions/setup-go digest to 3041bf5 (elastic#944) chore(deps): update dependency go to v1.23.4 (elastic#938) Bump actions/setup-go from 5.1.0 to 5.2.0 (elastic#958) chore(deps): update golang docker tag to v1.23.4 (elastic#939) fix(deps): update github.com/hashicorp/go-cty digest to a0325cb (elastic#934) chore(deps): update codecov/codecov-action digest to 1e68e06 (elastic#941) Bump github.com/golangci/golangci-lint from 1.62.2 to 1.63.4 in /tools (elastic#970) Prepare release v0.11.13 update team name (elastic#974) feat: update synthetics implementation according to Kibana 8.16 API changes (elastic#967) Add 8.17.0 to test matrix (elastic#969) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current acceptance setup code was not allowing me to use an API key even if it's now supported by Kibana.
This PR makes it to use api keys to run acceptance tests.
I didn't run the full acceptance test suite with this. Acceptance is passing for #948 with an API key.