Set empty relations as loaded too and prevent unnecessary database queries. #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y on the elastic document. This prevents future queries when accessing the relationship via the magic __get method.
Set empty relations as loaded.
|
mmmm.... Hi? |
Merge elasticquent/Elasticquent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing a relation via the magic __get method on Elasticquent loaded model, unnecessary queries to the datatabase are performed if the relation is empty,. For example:
If the properties related model (BelongsToMany relationship) is an empty array on ElasticSearch document the relation on the $product model isn't loaded and a query to the database is performed. With this fix we prevent this unnecessary queries.