Conversation
…r the `#[builder]` instead of before
anelson
approved these changes
Mar 15, 2025
Veetaha
deleted the
fix/add-warning-for-tracing-instrument-macro-ordering
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #259.
A new warning suggests moving the
#[tracing::instrument]before the#[builder]macro. Doing it as a warning because this check is heuristic and may technically have false positives for macros that use the nameinstrumenttoo. I don't know of any such macros, and if there are ones, I expect people will reach out and we'll work on a better solution.