-
Notifications
You must be signed in to change notification settings - Fork 13
Add conditional set-me in config #1980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 46 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
8e158ce
all: add conditional set-me in config
Ajarmar c623d21
fix failing test and add unit tests for conditional-set-me
Ajarmar 7c36189
update resources
Ajarmar 6dd35d0
fix changes to rclone config
Ajarmar ae46d18
fix failing tests related to swift
Ajarmar a7de0f1
update migration library to account for conditional set-mes
Ajarmar 6522ff2
account for azure changes
Ajarmar c790e0d
fix new conditional
Ajarmar 1a3d492
use new method of private copy
Ajarmar 6b246b4
netpol IPs should be a list
Ajarmar a2d2cd4
update resources again
Ajarmar e23c520
only ask abort once during validation
Ajarmar 1ab2f46
simplify init with conditional set-me
Ajarmar 4b1fa45
schema conditionals for letsencrypt
Ajarmar 8a333c8
schema conditionals for trivy netpols
Ajarmar dd323a7
schema conditionals for kured netpols
Ajarmar 6b354c2
schema conditionals for letsencrypt netpols
Ajarmar 9ee793d
schema conditionals for falco netpols
Ajarmar 8607060
schema conditionals and tests for externalDns netpols
Ajarmar 49e5a6e
schema conditionals and updated tests for coredns netpols
Ajarmar 1ab633a
schema conditionals for externaldns txtownerid
Ajarmar c8f43de
remove example for txtOwnerId
Ajarmar 3183afb
schema conditionals for opsGenieHeartbeat
Ajarmar 6612e61
schema conditionals for slack alerts
Ajarmar 12fee49
schema conditionals for objectStorageSwift netpols
Ajarmar f4c5b57
schema conditionals for harbor netpols
Ajarmar a54fbfa
schema conditionals for monitoring externalDataSources
Ajarmar acd68fc
schema conditionals for opensearch plugin netpols
Ajarmar fccafaa
schema conditionals for rclone objectStorage netpols
Ajarmar 689d1ee
schema conditionals and updated tests for rclone swift
Ajarmar b69d2ad
add missing config schema for rclone swift netpols
Ajarmar fb56f10
schema conditionals for rclone secondaryurl netpols
Ajarmar 7b87089
schema conditionals for ingressnginx override netpols
Ajarmar 1745796
schema conditionals for dex netpols
Ajarmar 364fa87
add tags for all conditional set-me tests
Ajarmar 30d1044
fix broken comment
Ajarmar 3ab2e33
remove unnecessary override config
Ajarmar 689cac7
don't test coredns serviceip since it is always set
Ajarmar c2e3bfd
fix failing tests
Ajarmar bbeb61c
only set openstack netpol ips on openstack envs
Ajarmar 2161551
update resources for update-ips test
Ajarmar b85231f
fix failing schema tests
Ajarmar 192e57f
bash cleanup
Ajarmar c9a211a
remove unused function
Ajarmar 4840881
update conditional for objectStorageSwift
Ajarmar d689108
fix swift test
Ajarmar e25dba6
less duplicated code
Ajarmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,6 @@ alerts: | |
| alertTo: opsgenie | ||
| opsGenieHeartbeat: | ||
| enabled: true | ||
| name: set-me | ||
|
|
||
| prometheus: | ||
| retention: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: could you extract the common parts for sc/wc and run them after the if-statements?
Something like this?