-
Notifications
You must be signed in to change notification settings - Fork 13
Upgrade OpenSearch to v2.17.1 #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a2969b9 to
6373d01
Compare
8d5566a to
076e9fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the migration only performs the specialised steps if we have a version diff on OpenSearch.
Else it should do a generic apply to ensure that is still is up to date in terms of config.
helmfile.d/upstream/opensearch-project/opensearch-dashboards/templates/serviceMonitor.yaml
Show resolved
Hide resolved
robinAwallace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, I know there where a lot of small things to figure out for this migration 😄 LGTM 👍
salehsedghpour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
aarnq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question else it LGTM.
OlleLarsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice to me, just have some small comments
2b43399 to
19b8539
Compare
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeCritical security fixes should be marked with
kind/securitySecurity notice
OpenSearch Dashboards was upgraded to
2.17.1which mitigates CVE-2024-45801What does this PR do / why do we need this PR?
Upgrades OpenSearch to Chart Version
2.26.1and OpenSearch Dashboards to Chart Version2.24.1, which upgrades the App Version to2.17.1. This mitigates CVE-2024-45801, which the current version ofdompurifyused in OpenSearch Dashboards is affected by. It also adds a fix for the "red screen" bug present for newer versions of Google Chrome. This PR also changes the name of the index that OpenSearch Dashboards uses to store saved objects (Visualizations e.t.c..) back to the default.kibana, as this name override was causing issues with System Index permissions, preventing access from all regular users includingadminand OpenSearch Dashboards. Changing this back to the default value also fixes the Reporting feature in OpenSearch Dashboards which has not been functional previously.Information to reviewers
Checklist
NetworkPolicy Dashboard