Skip to content

Conversation

@viktor-f
Copy link
Contributor

@viktor-f viktor-f commented Nov 27, 2024

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

Based on this internal product management discussion.

This PR drops a few falco rules and removes some of our special modifications to those rules.

Dropping these rules since they are a relatively weak indication of intrusion. They would also require a significant amount of tuning before they are really useful.

  • Read sensitive file trusted after startup
  • Read sensitive file untrusted

Dropping these rules since they produce significant spam due to false positives. For the same reasons they are also not a strong indication of intrusion.

  • Terminal shell in container
  • Contact K8S API Server From Container
  • Redirect STDOUT/STDIN to Network Connection in Container

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change upgrades CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@viktor-f viktor-f added the app/falco Falco - Intrusion Detection label Nov 27, 2024
@viktor-f viktor-f requested a review from a team as a code owner November 27, 2024 15:27
@viktor-f viktor-f force-pushed the vf/drop-falco-rules branch from 6422454 to 4e92595 Compare November 28, 2024 07:30
@viktor-f viktor-f merged commit 5048f03 into main Dec 3, 2024
12 checks passed
@viktor-f viktor-f deleted the vf/drop-falco-rules branch December 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app/falco Falco - Intrusion Detection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants