Skip to content

Conversation

@aarnq
Copy link
Contributor

@aarnq aarnq commented Dec 18, 2024

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

Enforces certain styling to bash scripts, especially indentation.
Let me know if there is something that seems off.

Information to reviewers

I'm also looking at other tools to complement it.

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change upgrades CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@aarnq aarnq requested a review from a team as a code owner December 18, 2024 15:01
@aarnq aarnq requested a review from a team December 18, 2024 15:01
@aarnq aarnq requested review from a team as code owners December 18, 2024 15:01
@aarnq aarnq mentioned this pull request Dec 18, 2024
35 tasks
Copy link
Contributor

@simonklb simonklb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love seeing us making use of more linters! 👍

@aarnq aarnq force-pushed the aarnq/update-templates branch from c60d69a to 98331f2 Compare December 20, 2024 07:33
@aarnq aarnq requested review from a team as code owners December 20, 2024 07:33
Base automatically changed from aarnq/update-templates to main December 20, 2024 07:43
@aarnq aarnq merged commit ff9ebac into main Dec 20, 2024
12 checks passed
@aarnq aarnq deleted the aarnq/formatters branch December 20, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants