Skip to content

Conversation

@aarnq
Copy link
Contributor

@aarnq aarnq commented Dec 30, 2024

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • [kind/adr](set-me)

What does this PR do / why do we need this PR?

This mirrors the Bitnami images used by Apps to ensure availability after their policy change is in effect starting the 7th.

I should note that this upgrades kubectl used by gatekeeper templates wait, as it was left on 1.25.

Information to reviewers

I believe this is it, others that were listed as potential ones to be mirrored:

  • fluentd-aggregator
    • is using a custom built image and is missing its containerfile
  • elasticsearch-curator
    • is using a custom built image
  • minio (as part of the thanos chart)
    • is not used (the minio chart for local-clusters is using another upstream)

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change updates CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts required no updates)
    • The metrics names did change (Grafana dashboards and Prometheus alerts required an update)
  • Logs checks:
    • The logs do not show any errors after the change
  • PodSecurityPolicy checks:
    • Any changed Pod is covered by Kubernetes Pod Security Standards
    • Any changed Pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any Pods to be blocked by Pod Security Standards or Policies
  • NetworkPolicy checks:
    • Any changed Pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@aarnq aarnq added the kind/improvement Improvement of existing features, e.g. code cleanup or optimizations. label Dec 30, 2024
@aarnq aarnq requested review from Xartos, viktor-f and vomba December 30, 2024 08:52
@aarnq aarnq self-assigned this Dec 30, 2024
@aarnq aarnq requested review from a team as code owners December 30, 2024 08:52
@aarnq aarnq merged commit c7eb740 into main Dec 30, 2024
14 checks passed
@aarnq aarnq deleted the aarnq/mirror-bitnami-images branch December 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Improvement of existing features, e.g. code cleanup or optimizations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants