Skip to content

Conversation

@AlbinB97
Copy link
Contributor

@AlbinB97 AlbinB97 commented Dec 17, 2025

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • [kind/adr](set-me)

What does this PR do / why do we need this PR?

Information to reviewers

Velero volume snapshots doesn't work on multi-zone clusters. This needs to investigated separately.

But it's confirmed working on Evroc by @viktor-f

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change updates CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts required no updates)
    • The metrics names did change (Grafana dashboards and Prometheus alerts required an update)
  • Logs checks:
    • The logs do not show any errors after the change
  • PodSecurityPolicy checks:
    • Any changed Pod is covered by Kubernetes Pod Security Standards
    • Any changed Pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any Pods to be blocked by Pod Security Standards or Policies
  • NetworkPolicy checks:
    • Any changed Pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@AlbinB97 AlbinB97 marked this pull request as ready for review December 18, 2025 12:44
@AlbinB97 AlbinB97 requested review from a team as code owners December 18, 2025 12:44
Copy link
Contributor

@Zash Zash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rarescosma rarescosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@elastisys-staffan elastisys-staffan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rarescosma rarescosma requested a review from a team as a code owner December 19, 2025 08:59
@rarescosma rarescosma requested a review from a team as a code owner December 19, 2025 10:03
@rarescosma
Copy link
Contributor

Added 14e4a87 as it was missing from the branch even though the changelog contained the PR 🤷🏼

@rarescosma rarescosma added the kind/release Creating a new release label Dec 19, 2025
@rarescosma rarescosma merged commit edfc5d1 into release-0.49 Dec 19, 2025
12 checks passed
@rarescosma rarescosma deleted the staging-0.49.2 branch December 19, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/release Creating a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants