-
Notifications
You must be signed in to change notification settings - Fork 10
Staging 2.26.0 ck8s1 #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging 2.26.0 ck8s1 #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how we usually do this, but should the changelog reflect changes from specific Kubespray commits that we have in our fork as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider adding the changes we have done in our fork to the changelog. As, these are changes that are present in the release and that some customer would like to know about. Specially the UpCloud changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should at least be a commit that says that we upgraded to kubespray 2.26 which I'm not seeing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also expect some relevant notes from upstream being here.
But then again, I see that we have not done that for other releases.
What do you think, should we start adding more notes from upstream release notes? And maybe a link to it? @Xartos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some changelog entries 31a8021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I would expect the release notes to have something similar to what we have in our latest postgres AMS changelog. Some of the bigger changes (Like the new default kubernetes version)
robinAwallace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The person that did the upgrade QA steps, did the updating of the terraform state work as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider adding the changes we have done in our fork to the changelog. As, these are changes that are present in the release and that some customer would like to know about. Specially the UpCloud changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also expect some relevant notes from upstream being here.
But then again, I see that we have not done that for other releases.
What do you think, should we start adding more notes from upstream release notes? And maybe a link to it? @Xartos
Yes :) |
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeCritical security fixes should be marked with
kind/securityWhat does this PR do / why do we need this PR?
Information to reviewers
Checklist
NetworkPolicy Dashboard