Skip to content

Conversation

@davidumea
Copy link
Contributor

@davidumea davidumea commented Nov 12, 2024

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@davidumea davidumea added the kind/release New release label Nov 12, 2024
@davidumea davidumea requested review from a team and lunkan93 November 12, 2024 13:24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how we usually do this, but should the changelog reflect changes from specific Kubespray commits that we have in our fork as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider adding the changes we have done in our fork to the changelog. As, these are changes that are present in the release and that some customer would like to know about. Specially the UpCloud changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should at least be a commit that says that we upgraded to kubespray 2.26 which I'm not seeing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also expect some relevant notes from upstream being here.
But then again, I see that we have not done that for other releases.
What do you think, should we start adding more notes from upstream release notes? And maybe a link to it? @Xartos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some changelog entries 31a8021

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I would expect the release notes to have something similar to what we have in our latest postgres AMS changelog. Some of the bigger changes (Like the new default kubernetes version)

Copy link
Contributor

@robinAwallace robinAwallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The person that did the upgrade QA steps, did the updating of the terraform state work as expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider adding the changes we have done in our fork to the changelog. As, these are changes that are present in the release and that some customer would like to know about. Specially the UpCloud changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also expect some relevant notes from upstream being here.
But then again, I see that we have not done that for other releases.
What do you think, should we start adding more notes from upstream release notes? And maybe a link to it? @Xartos

@davidumea
Copy link
Contributor Author

The person that did the upgrade QA steps, did the updating of the terraform state work as expected?

Yes :)

@davidumea davidumea merged commit 14f1e92 into release-2.26.0 Nov 14, 2024
2 checks passed
@davidumea davidumea deleted the staging-2.26.0-ck8s1 branch November 14, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/release New release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants