-
Notifications
You must be signed in to change notification settings - Fork 11
rook-ceph: add exporter psp and fix dashboard #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aarnq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the dashboard changes work with old v17 metrics?
Some of the panels seem to get the issue that this fixes when on v17 😵 |
aarnq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| app: rook-ceph-exporter | ||
| allow: | ||
| allowPrivilegeEscalation: true | ||
| privileged: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to allow privileged to be true? from what i can see of the exporter pod it runs it as false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably be removed, I did not have time to construct the PSP super carefully as this was found during maintenance
Just to clarify: I tested the changes on v17 and I found that not all, but for at least one panel the change actually introduces the issue on v17, that it fixes on v18. |
|
Well done thank you |
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeCritical security fixes should be marked with
kind/securityWhat does this PR do / why do we need this PR?
...
Information to reviewers
Checklist