Skip to content

Conversation

@FredrikCarlssn
Copy link
Contributor

@FredrikCarlssn FredrikCarlssn commented Jul 1, 2025

What kind of PR is this?

  • kind/bug

What does this PR do / why do we need this PR?

Bumps calico-accountant from 0.1.6-ck8s2 to 0.1.6-ck8s3.
This fixes an issue where, under Kubespray-based clusters, the
exporter could emit duplicate metric samples with identical label sets during
the same scrape interval.

This is linked to this PR on apps

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change updates CRDs
    • The change updates the config and the schema
  • Documentation checks:
    • The public documentation required no updates
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change
  • Logs checks:
    • The logs do not show any errors after the change
  • PodSecurityPolicy checks:
    • Any changed Pod is covered by Kubernetes Pod Security Standards
    • Any changed Pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any Pods to be blocked
  • NetworkPolicy checks:
    • Any changed Pod is covered by Network Policies
    • The change does not cause any dropped packets
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@FredrikCarlssn FredrikCarlssn requested a review from a team as a code owner July 1, 2025 21:20
Xartos
Xartos previously requested changes Jul 8, 2025
Copy link
Contributor

@Xartos Xartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since config isn't updated automatically, we'd need to add migration docs for this as well. This should also mention that the apps version needs to be a supported version

@FredrikCarlssn
Copy link
Contributor Author

FredrikCarlssn commented Jul 8, 2025

Since config isn't updated automatically, we'd need to add migration docs for this as well. This should also mention that the apps version needs to be a supported version

Absolutely, coming up. BTW do we actually know which version the [PR] will be in yet, or should we just have a placholder/note for the migration now?

@Xartos
Copy link
Contributor

Xartos commented Jul 9, 2025

Since config isn't updated automatically, we'd need to add migration docs for this as well. This should also mention that the apps version needs to be a supported version

Absolutely, coming up. BTW do we actually know which version the [PR] will be in yet, or should we just have a placholder/note for the migration now?

Assume it will be in the next release 2.28, and if you don't manage to get it merged before the feature freeze of 2.28 you just change it to 2.29

Copy link
Contributor

@rarescosma rarescosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@davidumea davidumea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you!

Added migration docs

Updated migration docs
@FredrikCarlssn FredrikCarlssn force-pushed the fredrikcarlssn/fixcertmanager branch from a18e968 to 674898b Compare July 28, 2025 11:38
@FredrikCarlssn FredrikCarlssn merged commit 570f8c9 into main Jul 28, 2025
2 checks passed
@FredrikCarlssn FredrikCarlssn deleted the fredrikcarlssn/fixcertmanager branch July 28, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants