-
Notifications
You must be signed in to change notification settings - Fork 11
fix(calico): remove pinned version #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Xartos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since config isn't updated automatically, we'd need to add migration docs for this as well. This should also mention that the apps version needs to be a supported version
Absolutely, coming up. BTW do we actually know which version the [PR] will be in yet, or should we just have a placholder/note for the migration now? |
Assume it will be in the next release 2.28, and if you don't manage to get it merged before the feature freeze of 2.28 you just change it to 2.29 |
rarescosma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
davidumea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thank you!
Added migration docs Updated migration docs
a18e968 to
674898b
Compare
What kind of PR is this?
What does this PR do / why do we need this PR?
Bumps
calico-accountantfrom0.1.6-ck8s2to0.1.6-ck8s3.This fixes an issue where, under Kubespray-based clusters, the
exporter could emit duplicate metric samples with identical label sets during
the same scrape interval.
This is linked to this PR on apps
Checklist