-
Notifications
You must be signed in to change notification settings - Fork 11
Add Cilium support in Kubespray 2.27 #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a80af1a to
3ae92fa
Compare
|
Following the CAPI lead, the installation of ServiceMonitors is now disabled by default. |
|
Dropping a reminder here that the "install ServiceMonitor CRD early" solution from CAPI needs to be ported to Kubespray as well. |
13b4276 to
dd6d527
Compare
69cf48b to
c81fa3b
Compare
Changed the implementation so that we only require backports and cherry-picks from upstream @Ajarmar can you take another look when you've got some spare time? |
c81fa3b to
44c81ef
Compare
lucianvlad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
|
Referencing changes to base config in CAPI that should be mirrored here, once the Cilium initiative on Kubespray picks up steam again: https://github.com/elastisys/ck8s-cluster-api/pull/406 |
Ajarmar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I like the new solution (haven't tested though).
I have one question: do we want any of this on main as well, for v2.28 and following releases?
Thank you! Why would we not want it on Also, I'd like to mention that upstream has some interesting ongoing work for installing CRDs early into the clusters, which might let us remove some of the diff in our fork. |
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-changeorkind/dev-changedepending on typeCritical security fixes should be marked with
kind/securityRelease notes
Cilium values are controlled via
group_vars/all/k8s_cluster/ck8s-cilium.yamland mimic the structure of their CAPI equivalent.Platform Administrator notice
A migration or devbox templates will be required to copy over the new
group_vars/all/k8s_cluster/ck8s-cilium.yamlfile.Additionally, to enable the installation the following changes are required in
group_vars/all/k8s_cluster/ck8s-k8s-cluster.yaml:What does this PR do / why do we need this PR?
Adds experimental support for running Cilium as CNI in Kubespray clusters.
Information to reviewers
Checklist