Split API into one distinct type per device variant.#17
Open
reitermarkus wants to merge 12 commits intoeldruin:masterfrom
Open
Split API into one distinct type per device variant.#17reitermarkus wants to merge 12 commits intoeldruin:masterfrom
reitermarkus wants to merge 12 commits intoeldruin:masterfrom
Conversation
reitermarkus
force-pushed
the
split-api
branch
from
56fecb6 to
6c12cc8
Compare
reitermarkus
force-pushed
the
split-api
branch
5 times, most recently
from
df5f9a1 to
f52e787
Compare
Owner
|
Sorry, I'm coming back to this after a long time. What is the actual benefit of this API change? |
Contributor
Author
|
I think the main benefits are:
|
Owner
|
Thanks! As it stands this PR contains many other changes, though. Are you still willing to push this forward? |
reitermarkus
force-pushed
the
split-api
branch
from
f49cd40 to
9ea1a39
Compare
Merged
Contributor
Author
|
@eldruin, opened a new PR with only the doc changes. |
reitermarkus
force-pushed
the
split-api
branch
2 times, most recently
from
c6f5bc1 to
1d5c6b5
Compare
# Conflicts: # README.md # examples/all_channels.rs # examples/linux.rs # examples/typed.rs # src/construction.rs # src/devices/features/tier2.rs # src/lib.rs # tests/common/mod.rs # Conflicts: # src/channel.rs # src/devices/common.rs # src/devices/features/tier1.rs # src/devices/features/tier2.rs # src/devices/mode/continuous.rs # src/devices/mode/oneshot.rs # src/lib.rs # src/types.rs
# Conflicts: # src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be rebased after #16 is merged.