make aggregates explicitly optional on a groupBy #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwillis
force-pushed
the
samwillis/groupby-with-no-aggrigate
branch
from
7621a22 to
e912543
Compare
samwillis
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR makes the aggregates parameter on groupBy optional, adds a test case covering the new default behavior, and updates the project’s changeset.
- Allow callers to omit the
aggregatesargument ingroupByby defaulting to an empty object. - Add a unit test verifying
groupByworks without any aggregates. - Update the changeset description to reflect the optional-aggregates change.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/d2mini/src/operators/groupBy.ts | Default aggregates parameter to {} |
| packages/d2mini/tests/operators/groupBy.test.ts | New test: groupBy without aggregates |
| .changeset/clear-impalas-stare.md | Release notes for optional-aggregates feature |
Comments suppressed due to low confidence (1)
packages/d2mini/tests/operators/groupBy.test.ts:18
- [nitpick] The test name 'with no aggregate' could be clearer as 'without aggregates' to better describe running
groupBywith zero aggregates.
test('with no aggregate', () => {
.changeset/clear-impalas-stare.md
Outdated
| '@electric-sql/d2mini': patch | ||
| --- | ||
|
|
||
| make aggrigates explicity optional on a groupBy |
There was a problem hiding this comment.
Correct spelling in the changeset description: 'aggrigates' → 'aggregates' and 'explicity' → 'explicitly'.
Suggested change
| make aggrigates explicity optional on a groupBy | |
| make aggregates explicitly optional on a groupBy |
| K extends GroupKey, | ||
| A extends Record<string, AggregateFunction<T, any, any>>, | ||
| >(keyExtractor: (data: T) => K, aggregates: A) { | ||
| >(keyExtractor: (data: T) => K, aggregates: A = {} as A) { |
There was a problem hiding this comment.
[nitpick] Using {} as A to default aggregates can hide type mismatches. Consider adding an overload or refining the type parameters to support an omitted-aggregates case without forcing a cast.
KyleAMathews
approved these changes
Jun 17, 2025
cursor bot
pushed a commit
to samwillis/d2ts
that referenced
this pull request
Jul 13, 2025
* make aggrigates explicity optional on a groupBy * changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.