fix: groupBy to correctly remove groups when a key is completely removed #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwillis
force-pushed
the
samwillis/groupby-delete
branch
from
bb3e85e to
b4e2727
Compare
15 tasks
cursor bot
pushed a commit
to samwillis/d2ts
that referenced
this pull request
Jul 13, 2025
…ved (electric-sql#70) * fix: index compaction for reduce * changeset * repo of bug * fix groupby bug * changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is that when a groupBy key is completely removed the group would remain but have the aggregates changed to 0 or equivalent.
stacked on #69