Conversation
samwillis
approved these changes
Jul 7, 2025
Contributor
samwillis
left a comment
samwillis
left a comment
There was a problem hiding this comment.
LGTM - Needs a changeset
cursor bot
pushed a commit
to samwillis/d2ts
that referenced
this pull request
Jul 13, 2025
* Revert back to map implementation of index * Modify index tests to no longer assert uncompacted form * Remove obsolete comments * changeset * Refactor reduce * Update changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes to the index from #69
This means we are keeping the consolidated multiplicity instead of an array of multiplicities that needs to be consolidated at compaction time. By keeping a map of consolidated values it is cheaper to get a value's multiplicity, which is important for the efficient topK operator from #72