fix(Vue): nullish params in useLiveQueryImpl#466
Merged
samwillis merged 5 commits intoelectric-sql:mainfrom Jan 13, 2025
Merged
fix(Vue): nullish params in useLiveQueryImpl#466samwillis merged 5 commits intoelectric-sql:mainfrom
useLiveQueryImpl#466samwillis merged 5 commits intoelectric-sql:mainfrom
Conversation
useLiveQueryImpl
Contributor
|
@samwillis this PR typically fixes #448 |
Contributor
Author
|
Indeed, thank you @yacineb 🙏 |
Contributor
Author
|
marked as draft because I think I could improve it further |
Contributor
Author
|
These latest changes both makes sure that the watcher receives an array of refs as well as returning getters values if |
samwillis
approved these changes
Jan 13, 2025
Collaborator
samwillis
left a comment
There was a problem hiding this comment.
Thanks @sandros94, this is great. I added a changeset, a test and fixed some formatting in your branch. Going to merge now 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small oversight on
useLiveQueryanduseLiveIncrementalQuerywhenparamsare nullish.Eg. if we want to go brrr and subscribe to all updates to a particular table like: