Skip to content

New gh action to pnpm i and pnpm build:all#520

Merged
tdrz merged 10 commits intomainfrom
tudor/installBuildAsReadme
Feb 5, 2025
Merged

New gh action to pnpm i and pnpm build:all#520
tdrz merged 10 commits intomainfrom
tudor/installBuildAsReadme

Conversation

@tdrz
Copy link
Collaborator

@tdrz tdrz commented Feb 4, 2025

We want to run a CI action that mimics the README.md instructions as close as possible.

@tdrz tdrz requested a review from samwillis February 4, 2025 15:36
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to get this in.

We can de-duplacate the work flows later, but having this tested makes sense.

Is it worth adding a pnpm test at the end, or should we wait till we have this as the main workflow?

@tdrz
Copy link
Collaborator Author

tdrz commented Feb 4, 2025

Is it worth adding a pnpm test at the end, or should we wait till we have this as the main workflow?

Good idea, just added it, will wait for the CI and then merge.

@tdrz
Copy link
Collaborator Author

tdrz commented Feb 4, 2025

@samwillis test fail on that action... hm...

@tdrz
Copy link
Collaborator Author

tdrz commented Feb 5, 2025

@samwillis Will merge this without running the tests. Made a separate PR for that and will look into fixing it.

@tdrz tdrz merged commit ea110d1 into main Feb 5, 2025
8 checks passed
@tdrz tdrz deleted the tudor/installBuildAsReadme branch February 5, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants