Mandatory shapeKey on syncShapeToTable; allow shapeKey to be null#522
Merged
Mandatory shapeKey on syncShapeToTable; allow shapeKey to be null#522
Conversation
Contributor
samwillis
approved these changes
Feb 5, 2025
Collaborator
samwillis
left a comment
samwillis
left a comment
There was a problem hiding this comment.
Perfect 👍
Looks like there is a formatting issue in test/sync.test.ts. Just run pnpm format in /packages/pglite (I think)
Collaborator
|
Oh, and don't forget a changeset noting the change in api - its still just a patch version change to the pglite-sync package though! |
added 2 commits
February 5, 2025 10:16
Contributor
|
🚀 Deployed on https://67a330757752fd2c4bf81cfc--pglite.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Discord, make
shapeKeymandatory but allow it to be null for non-persisted shapes.