Fix failure on installing large ipa: send packet (afc): write unix ->…#45
Open
larryhou wants to merge 1 commit intoelectricbubble:mainfrom
Open
Fix failure on installing large ipa: send packet (afc): write unix ->…#45larryhou wants to merge 1 commit intoelectricbubble:mainfrom
larryhou wants to merge 1 commit intoelectricbubble:mainfrom
Conversation
…/var/run/usbmuxd: write: broken pipe
electricbubble
requested changes
Dec 19, 2023
Comment on lines
+417
to
420
| if r, err := os.Open(ipaPath); err != nil {return err} else { | ||
| defer r.Close() | ||
| if err = d.afc.WriteFile(installationPath, r, AfcFileModeWr); err != nil {return err} | ||
| } |
Owner
There was a problem hiding this comment.
🤔 It would be better to close the file as soon as possible
_ipaFile, err := os.Open(ipaPath)
if err != nil {
return err
}
if err = d.afc.WriteFile(installationPath, _ipaFile, AfcFileModeWr); err != nil {
_ipaFile.Close()
return err
}
_ipaFile.Close()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failure on installing large ipa, in my case the file size is greater than 4GB
send packet (afc): write unix ->/var/run/usbmuxd: write: broken pipe