add functionality to retain scroll position on zone details on zone/t…#8547
Closed
DanNguyen8189 wants to merge 1 commit intoelectricitymaps:masterfrom
Closed
add functionality to retain scroll position on zone details on zone/t…#8547DanNguyen8189 wants to merge 1 commit intoelectricitymaps:masterfrom
DanNguyen8189 wants to merge 1 commit intoelectricitymaps:masterfrom
Conversation
Member
|
Thanks for contributing! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ime switch
Issue
#7618
Add functionality to retain scroll position on zone details when selecting another zone/country or timeframe
Description
useScrollHashIntoView, the function responsible for scrolling the zone details panel, depended on useLocation() variables (hash,pathname,search). However, they were not changing as the user scrolled. The function saw that hash/anchor was blank and would scroll to the top every time the zone or time was switched.
Modifications:
It's possible that using useLocation() may still work if we set the hash onto the url when the user scrolls (change useUpdateHashOnScroll to do this) and move useLocation() inside the useEffect instead
Preview
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.