Skip to content

Conversation

@xconverge
Copy link
Contributor

@xconverge xconverge commented Oct 16, 2024

Pretty simple getters I found useful to calculate where in the loop I am to display, I did not find IsNearBeginning to be sufficient for my needs.

I am using it like this

  float percentageDone = 100.0 * (m_looperL.GetPos() / m_looperL.GetRecSize());

The formatting changes were so minor I thought it didn't impact the reviewability of the PR

Also added variable playback speed option

@stephenhensley
Copy link
Collaborator

Looks good to me! Definitely helpful additions!

Thanks for the contribution!

@stephenhensley stephenhensley merged commit 599511b into electro-smith:master May 29, 2025
2 checks passed
@xconverge xconverge deleted the looperGetters branch May 29, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants