Skip to content

Fix SetLedRaw overflow bug #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
beserge wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fix SetLedRaw overflow bug #415

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73f93b0
Fix SetLedRaw overflow bug
beserge Oct 8, 2021
20fb63e
Only send buffer if an led is updated
beserge Oct 12, 2021
372865c
clang-format
beserge Oct 12, 2021
3527cdf
First pass at direct addressing buffers
beserge Nov 4, 2021
ca8a30a
Formatting
beserge Nov 4, 2021
89acc40
Get transfers working per updated led
beserge Jan 3, 2022
effaff7
Start with update all leds
beserge Jan 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dev/leddriver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class LedDriverPca9685
const auto on = draw_buffer_[d].leds[ch].on & (0x0FFF);
draw_buffer_[d].leds[ch].off = (on + rawBrightness) & (0x0FFF);
// full on condition
if(rawBrightness >= 0x0FFF)
if(rawBrightness + on >= 0x0FFF)
draw_buffer_[d].leds[ch].on = 0x1000 | on; // set "full on" bit
else
draw_buffer_[d].leds[ch].on = on; // clear "full on" bit
Expand Down