Fix shellcheck SC2043 and triage workflow label permissions#250
Merged
electrocucaracha merged 4 commits intomasterfrom Mar 16, 2026
Merged
Fix shellcheck SC2043 and triage workflow label permissions#250electrocucaracha merged 4 commits intomasterfrom
electrocucaracha merged 4 commits intomasterfrom
Conversation
Co-authored-by: electrocucaracha <2782150+electrocucaracha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix linting issues and run make commands
Fix SPELL_CODESPELL linting failures and add codespell configuration
Mar 15, 2026
Co-authored-by: electrocucaracha <2782150+electrocucaracha@users.noreply.github.com>
Copilot
AI
changed the title
Fix SPELL_CODESPELL linting failures and add codespell configuration
Fix CI linting failures: codespell errors, wordlist, and workflow permissions
Mar 15, 2026
Co-authored-by: electrocucaracha <2782150+electrocucaracha@users.noreply.github.com>
Copilot
AI
changed the title
Fix CI linting failures: codespell errors, wordlist, and workflow permissions
Fix shellcheck SC2043 and triage workflow label permissions
Mar 15, 2026
Review Summary by QodoFix linting issues: shellcheck, codespell, and workflow permissions
WalkthroughsDescription• Fix shellcheck SC2043 by removing single-item for loop in _installers.sh • Add pull-requests: write permission to triage workflow for labeler action • Fix multiple spelling errors across shell scripts and configuration files • Add codespell configuration with custom wordlist for linting • Update linter workflow permissions and failed-build-issue-action parameters Diagramflowchart LR
A["Linting Issues"] --> B["Shellcheck SC2043"]
A --> C["Codespell Errors"]
A --> D["Workflow Permissions"]
B --> E["Remove for loop in _installers.sh"]
C --> F["Fix spelling in multiple files"]
C --> G["Add .codespellrc config"]
D --> H["Add pull-requests:write to triage.yml"]
D --> I["Update linter.yml permissions"]
File ChangesView more (11)8. .github/.wordlist.txt
|
Code Review by Qodo
1. Spellcheck breaks on AddOns
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| NodeLocal | ||
| NODELOCALDNS | ||
| ol | ||
| Ons |
There was a problem hiding this comment.
1. Spellcheck breaks on addons 🐞 Bug ⛯ Reliability
The PR removes the wordlist entry Ons while the repo still contains the camel-cased term AddOns in README/scripts, so spellchecking/linting that uses this wordlist will start flagging it and can fail CI. This is amplified because .codespellrc newly points codespell to the same .github/.wordlist.txt file.
Agent Prompt
### Issue description
CI spelling/lint checks rely on `.github/.wordlist.txt`. The PR removes `Ons` from this wordlist, but the repo still uses `AddOns` in documentation and scripts, and `.codespellrc` now shares the same wordlist with codespell.
### Issue Context
- `pyspelling` consumes `.github/.wordlist.txt`.
- `codespell` is newly configured to consume the same wordlist.
- `AddOns` still appears in README/scripts.
### Fix Focus Areas
- .github/.wordlist.txt[72-86]
- README.md[125-134]
- _installers.sh[161-169]
- .codespellrc[1-2]
- .spellcheck.yml[10-21]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI failures on PR #250: shellcheck SC2043 in
_installers.shandactions/labelerfailing with 403 due to insufficient permissions.Changes
_installers.sh: Remove single-itemfor addon in grafanaloop (SC2043 — loop never iterates more than once); replace with direct inline commands.github/workflows/triage.yml: Addpull-requests: writepermission required byactions/labelerto assign labels📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.