remove iOS container #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liulianci
force-pushed
the
scriptToAddContainer
branch
from
972c741 to
174c98a
Compare
Member
friederbluemle
left a comment
friederbluemle
left a comment
There was a problem hiding this comment.
Awesome! 👍
The new script does not show up in the diff (too many changes). Can you please either use two separate commits, or just paste the script to the PR description for review?
liulianci
force-pushed
the
scriptToAddContainer
branch
from
174c98a to
4a65637
Compare
Contributor
|
Thanks @liulianci |
liulianci
force-pushed
the
scriptToAddContainer
branch
5 times, most recently
from
057fd1f to
044d0f6
Compare
Contributor
Author
|
This is part of PR #60 |
liulianci
force-pushed
the
scriptToAddContainer
branch
from
044d0f6 to
d0a6e2c
Compare
add ElectrodeContainer to embed frameworks to fix a crash on Device: dyld: Library not loaded: @rpath/ElectrodeContainer.framework/ElectrodeContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a script to create container. run
./ios/createContainer.shto get iOS container