Warning and workaround for error in electron #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, this doc update tells the user how to deal with electron/electron#41614 |
nikwen
suggested changes
Jun 23, 2025
|
How do you feel about this rewording that drops the suggestion? The workaround text is less important to me than the warning so users can avoid a situation where they (...me) do exactly as suggested - and end up with error/warning messages. |
|
Thanks for the update! I still wouldn't mention it in the Forge docs because it's not an issue with Forge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron has a wontfix error that impacts the webpack template workflow.
This PR adds a warning to the docs, and a suggested workaround.