This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Pass filePath to compiler.shouldCompileFile() instead of code#260
Open
alreece45 wants to merge 1 commit intoelectron-userland:masterfrom
Open
Pass filePath to compiler.shouldCompileFile() instead of code#260alreece45 wants to merge 1 commit intoelectron-userland:masterfrom
filePath to compiler.shouldCompileFile() instead of code#260alreece45 wants to merge 1 commit intoelectron-userland:masterfrom
Conversation
filePath to compiler.shouldCompileFile() instaed of codefilePath to compiler.shouldCompileFile() instead of code
This was referenced Aug 15, 2017
Author
|
It looks like there was an issue with |
eliot-akira
added a commit
to eliot-akira/electron-compile
that referenced
this pull request
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldCompileFile()is passedcode, instead offilePath. The tests also suggest that the expected return value isfilePath, rather thancode. This commit corrects both to usefilePathCode loading is shifted so that it is only loaded when
shouldCompileFile()returns true, rather than always.