Skip to content

chore: properly filter unsupported Electron versions #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: properly filter unsupported Electron versions #139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c078dbb
Exclude older Electron versions in setVersions()
Mar 16, 2025
2ceccb0
Exclude older Electron versions in setVersions()
Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions src/versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as fs from 'fs-extra';
import { parse as semverParse, SemVer } from 'semver';
import { parse as semverParse, SemVer, gte } from 'semver';
import debug from 'debug';
import fetch from 'node-fetch';

Expand Down Expand Up @@ -157,11 +157,20 @@ export class BaseVersions implements Versions {
// build the array
let parsed: Array<SemVer | null> = [];
if (isArrayOfVersionObjects(val)) {
parsed = val.map(({ version }) => semverParse(version));
parsed = val
.map(({ version }) => semverParse(version))
.filter((sem) => sem && gte(sem, '0.30.0')) // Standalone gte
.filter((sem) => !sem.version.startsWith('0.2')); // Exclude atom-shell

// build release info
for (const entry of val) {
if (isReleaseInfo(entry)) {
const parsedVersion = semverParse(entry.version);
if (
isReleaseInfo(entry) &&
parsedVersion &&
gte(parsedVersion, '0.30.0') &&
!entry.version.startsWith('0.2')
){
this.releaseInfo.set(entry.version, {
version: entry.version,
date: entry.date,
Expand All @@ -177,7 +186,10 @@ export class BaseVersions implements Versions {
}
}
} else if (isArrayOfStrings(val)) {
parsed = val.map((version) => semverParse(version));
parsed = val
.map((version) => semverParse(version))
.filter((sem) => sem && gte(sem, '0.30.0'))
.filter((sem) => !sem.version.startsWith('0.2'));
} else {
console.warn('Unrecognized versions:', val);
}
Expand Down