Skip to content

Commit b1fd200

Browse files
refactor: integrate fiddle-core (#1134)
* refactor: integrate fiddle-core to renderer process * upgrade to [email protected] * build: fiddle-core to @vertedinde/fiddle-core1.0.3 Co-authored-by: VerteDinde <[email protected]>
1 parent 6995022 commit b1fd200

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+917
-1292
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@
3838
"@blueprintjs/core": "^3.36.0",
3939
"@blueprintjs/popover2": "^0.12.2",
4040
"@blueprintjs/select": "^3.15.0",
41-
"@electron/get": "^2.0.0",
4241
"@octokit/rest": "^16.43.1",
4342
"@sentry/electron": "^2.5.3",
43+
"@vertedinde/fiddle-core": "^1.0.3",
4444
"algoliasearch": "^4.12.0",
4545
"classnames": "^2.2.6",
4646
"commander": "^7.1.0",

rtl-spec/commands-bisect.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import * as React from 'react';
22

33
import { render } from '@testing-library/react';
44
import userEvent from '@testing-library/user-event';
5+
import { InstallState } from '@vertedinde/fiddle-core';
56

6-
import { VersionState } from '../src/interfaces';
77
import { BisectHandler } from '../src/renderer/components/commands-bisect';
88
import { AppState } from '../src/renderer/state';
99
import { StateMock } from '../tests/mocks/state';
@@ -16,7 +16,7 @@ describe('Bisect commands component', () => {
1616
});
1717

1818
it('is disabled if an electron version is currently downloading', () => {
19-
store.currentElectronVersion.state = VersionState.downloading;
19+
store.currentElectronVersion.state = InstallState.downloading;
2020
const { getByRole } = render(
2121
<BisectHandler appState={(store as unknown) as AppState} />,
2222
);

src/interfaces.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
1+
import { InstallState } from '@vertedinde/fiddle-core';
2+
13
export type Files = Map<string, string>;
24

35
export type FileTransform = (files: Files) => Promise<Files>;
46

5-
export enum VersionState {
6-
ready = 'ready',
7-
downloading = 'downloading',
8-
unzipping = 'unzipping',
9-
unknown = 'unknown',
10-
}
11-
127
export enum VersionSource {
138
remote = 'remote',
149
local = 'local',
@@ -41,7 +36,7 @@ export enum RunResult {
4136
}
4237

4338
export interface RunnableVersion extends Version {
44-
state: VersionState;
39+
state: InstallState;
4540
source: VersionSource;
4641
downloadProgress?: number;
4742
}

src/renderer/binary.ts

Lines changed: 0 additions & 283 deletions
This file was deleted.

src/renderer/components/commands-bisect.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import * as React from 'react';
22

33
import { Button } from '@blueprintjs/core';
4+
import { InstallState } from '@vertedinde/fiddle-core';
45
import { observer } from 'mobx-react';
56

6-
import { VersionState } from '../../../src/interfaces';
77
import { AppState } from '../state';
88

99
interface BisectHandlerProps {
@@ -60,7 +60,7 @@ export const BisectHandler = observer(
6060
const { appState } = this.props;
6161
if (!!appState.Bisector) {
6262
const isDownloading =
63-
appState.currentElectronVersion.state === VersionState.downloading;
63+
appState.currentElectronVersion.state === InstallState.downloading;
6464
return (
6565
<>
6666
<Button

0 commit comments

Comments
 (0)