feat: add run from ASAR button

src/renderer/components/commands-runner.tsx

@@ -1,6 +1,7 @@
 import * as React from 'react';
 
-import { Button, ButtonProps, Spinner } from '@blueprintjs/core';
+import { Button, ButtonGroup, ButtonProps, Spinner } from '@blueprintjs/core';
+import { Popover2 } from '@blueprintjs/popover2';
 import { observer } from 'mobx-react';
 
 import { InstallState, VersionSource } from '../../interfaces';
@@ -16,6 +17,30 @@ interface RunnerProps {
  */
 export const Runner = observer(
   class Runner extends React.Component<RunnerProps> {
+    private renderAsarButton = (disabled: boolean) => {
+      const asarButton = (
+        <Button
+          text="Run from ASAR"
+          icon="play"
+          disabled={disabled}
+          small
+          onClick={() => {
+            window.app.runner.run({ runFromAsar: true });
+          }}
+        />
+      );
+
+      return (
+        <Popover2 fill={true} content={asarButton} placement="bottom">
+          <Button
+            icon="caret-down"
+            style={{ minWidth: 20 }}
+            disabled={disabled}
+          />
+        </Popover2>
+      );
+    };
+
     public render() {
       const { downloaded, downloading, missing, installing, installed } =
         InstallState;
@@ -59,7 +84,9 @@ export const Runner = observer(
             props.icon = <Spinner size={16} />;
           } else {
             props.text = 'Run';
-            props.onClick = window.app.runner.run;
+            props.onClick = () => {
+              window.app.runner.run({ runFromAsar: false });
+            };
             props.icon = 'play';
           }
           break;
@@ -76,8 +103,15 @@ export const Runner = observer(
           props.icon = <Spinner size={16} />;
         }
       }
+      const isAsarDisabled: boolean =
+        props.disabled || isRunning || isInstallingModules;
 
-      return <Button id="button-run" {...props} type={undefined} />;
+      return (
+        <ButtonGroup>
+          <Button id="button-run" {...props} type={undefined} />
+          {this.renderAsarButton(isAsarDisabled)}
+        </ButtonGroup>
+      );
     }
   },
 );

src/renderer/components/commands.tsx

@@ -55,6 +55,8 @@ export const Commands = observer(
             </ControlGroup>
             <ControlGroup fill={true} vertical={false}>
               <VersionChooser appState={appState} />
+            </ControlGroup>
+            <ControlGroup fill={true} vertical={false}>
               <Runner appState={appState} />
             </ControlGroup>
             {isBisectCommandShowing && (

src/renderer/runner.ts

@@ -20,11 +20,16 @@ export enum ForgeCommands {
   MAKE = 'make',
 }
 
+interface runOptions {
+  runFromAsar: boolean;
+}
+
 interface RunFiddleParams {
   localPath: string | undefined;
   isValidBuild: boolean; // If the localPath is a valid Electron build
   version: string; // The user selected version
   dir: string;
+  runFromAsar: boolean;
 }
 
 const resultString: Record<RunResult, string> = Object.freeze({
@@ -139,8 +144,9 @@ export class Runner {
   /**
    * Actually run the fiddle.
    */
-  public async run(): Promise<RunResult> {
+  public async run(runOptions?: runOptions): Promise<RunResult> {
     const options = { includeDependencies: false, includeElectron: false };
+    const runFromAsar = runOptions?.runFromAsar ?? false;
 
     const { appState } = this;
     const currentRunnable = appState.currentElectronVersion;
@@ -220,6 +226,7 @@ export class Runner {
       isValidBuild,
       dir,
       version,
+      runFromAsar,
     });
   }
 
@@ -362,12 +369,15 @@ export class Runner {
    * or the user selected electron version
    */
   private async runFiddle(params: RunFiddleParams): Promise<RunResult> {
-    const { version, dir } = params;
+    const { version, dir, runFromAsar } = params;
     const { pushOutput, flushOutput, executionFlags } = this.appState;
     const env = this.buildChildEnvVars();
 
     // Add user-specified cli flags if any have been set.
     const options = [dir, '--inspect'].concat(executionFlags);
+    if (runFromAsar) {
+      options.push('runFromAsar');
+    }
 
     const cleanup = async () => {
       flushOutput();