Skip to content

Fix/cloudflare r2 skip checksum#3808

Draft
sebbean wants to merge 3 commits intoelectron:mainfrom
bean-la:fix/cloudflare-r2-skip-checksum
Draft

Fix/cloudflare r2 skip checksum#3808
sebbean wants to merge 3 commits intoelectron:mainfrom
bean-la:fix/cloudflare-r2-skip-checksum

Conversation

@sebbean
Copy link
Copy Markdown

@sebbean sebbean commented Jan 20, 2025

Enables pass through for s3RequestChecksumCalculation S3Client option

  publishers: [
    {
      name: '@electron-forge/publisher-s3',
      config: {
        s3RequestChecksumCalculation: 'WHEN_REQUIRED', // cloudflare fix

Can be used to get around Cloudflare R2's lack of checksum support.

An unhandled rejection has occurred inside Forge:
NotImplemented: Header 'x-amz-checksum-algorithm' with value 'CRC32' not implemented
at throwDefaultError (/Users/seb/dev/Streem/slyce-studio-mono/node_modules/.pnpm/@smithy+smithy-client@4.1.2/node_modules/@smithy/smithy-client/dist-cjs/index.js:867:20)
    at /Users/seb/dev/Streem/slyce-studio-mono/node_modules/.pnpm/@smithy+smithy-client@4.1.2/node_modules/@smithy/smithy-client/dist-cjs/index.js:876:5
    at de_CommandError (/Users/seb/dev/Streem/slyce-studio-mono/node_modules/.pnpm/@aws-sdk+client-s3@3.731.1/node_modules/@aws-sdk/client-s3/dist-cjs/index.js:4965:14)
  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant